Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK/Components - More meaningful error when trying to convert graph component to ContainerOp #710

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jan 21, 2019

This change is Reviewable

@gaoning777
Copy link
Contributor

Since there is not going to be a graph component now, why add the if-statement here? Maybe we should add graph component related codes when it is part of the component yaml.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 22, 2019

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 23, 2019

Since there is not going to be a graph component now

As was decided during the graph component meeting scope, there will be graph components.
But you are unblocked, because may may implement the features you want in the old compiler instead of waiting for the new one.

why add the if-statement here?

To improve the experience of people using the existing compiler that does not support the nested pipelines.

Maybe we should add graph component related codes when it is part of the component yaml.

I'm not sure it's good idea. I was asked by Bradley to make my PRs as small as possible.
Delaying the code additions and then dumping them all at once will make it hard to review. It also makes things hard to review and develop, because later commits rely on previous fixes and changes.
I'd prefer not to do 1000-line code reviews.
For this to happen there needs to be a steady stream of small PRs coming through review.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 23, 2019

/test kubeflow-pipeline-build-image

@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4457e7e into kubeflow:master Jan 25, 2019
@Ark-kun Ark-kun deleted the SDK/Components---More-meaningful-error-when-trying-to-convert-graph-component-to-ContainerOp branch April 22, 2019 23:19
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants