Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK - Removed stray debug print from tests #701

Merged
merged 1 commit into from
Jan 23, 2019
Merged

SDK - Removed stray debug print from tests #701

merged 1 commit into from
Jan 23, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jan 18, 2019 •
edited by jlewi
Loading

This change is Reviewable

gaoning777
gaoning777 approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 18, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 18, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 21, 2019

/test kubeflow-pipeline-e2e-test

@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 22, 2019

/test kubeflow-pipeline-e2e-test

1 similar comment
@neuromage
Copy link
Contributor

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 22, 2019

/test kubeflow-pipeline-build-image

@k8s-ci-robot k8s-ci-robot merged commit 0c92b83 into kubeflow:master Jan 23, 2019
@Ark-kun Ark-kun deleted the SDK---Removed-stray-debug-pring-from-tests branch January 23, 2019 02:05
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@jinchihe
enhance creds for cases that cannot get data secret data key from con…
a512d3c 
…figmap (kubeflow#701)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 approved these changes

@qimingj qimingj Awaiting requested review from qimingj

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@gaoning777 gaoning777

@qimingj qimingj

@hongye-sun hongye-sun

Labels
approved area/sdk lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ark-kun @k8s-ci-robot @hongye-sun @neuromage @gaoning777 @qimingj