Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): View pipeline from run ID in KFPv2. Fix #6758 #6759

Merged
merged 4 commits into from
Oct 25, 2021
Merged

feat(frontend): View pipeline from run ID in KFPv2. Fix #6758 #6759

merged 4 commits into from
Oct 25, 2021

Conversation

zijianjoy
Copy link
Collaborator

@zijianjoy zijianjoy commented Oct 18, 2021 •
edited
Loading

Description of your changes:

Fix #6758

  1. Move mocked data to a dedicated folder in mock-backend.
  2. View pipeline from an existing Run.
  3. Create Run from such pipeline in above step.
  4. Update the Pipeline View hyperlink in NewRun page.
viewpipelinefromrun.mov

Checklist:

@zijianjoy zijianjoy requested a review from Bobgy October 18, 2021 22:46
@google-cla google-cla bot added the cla: yes label Oct 18, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zijianjoy
Copy link
Collaborator Author

/retest-required

2 similar comments
@zijianjoy
Copy link
Collaborator Author

/retest-required

@zijianjoy
Copy link
Collaborator Author

/retest-required

@google-oss-robot google-oss-robot merged commit b7a455d into kubeflow:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Awaiting requested review from Bobgy

@StefanoFioravanzo StefanoFioravanzo Awaiting requested review from StefanoFioravanzo

Assignees
No one assigned
Labels
approved cla: yes lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[KFPv2] Handle the path from run list -> pipeline detail, which user created run without uploading pipeline.
2 participants
@zijianjoy @google-oss-robot