Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog to pipeline repo #644

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Add changelog to pipeline repo #644

merged 1 commit into from
Jan 7, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Jan 7, 2019

This is autogenerated by
https://github.com/github-changelog-generator/github-changelog-generator

github-changelog-generator have option to create changelog by special label but i don't see a point of doing so for now.


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Jan 7, 2019

/assign @yebrahim @pavel

@k8s-ci-robot
Copy link
Contributor

@IronPan: GitHub didn't allow me to assign the following users: pavel.

Note that only kubeflow members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @yebrahim @pavel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@IronPan: GitHub didn't allow me to assign the following users: pavel.

Note that only kubeflow members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @yebrahim @pavel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yebrahim
Copy link
Contributor

yebrahim commented Jan 7, 2019

Sweet!
Can you add instructions on how to generate this to the README?
/lgtm

@IronPan
Copy link
Member Author

IronPan commented Jan 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit be66644 into master Jan 7, 2019
@IronPan IronPan deleted the cl branch January 16, 2019 23:32
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
…ubeflow#645)

* Management cluster is a cluster running Cloud Config connector which
  can be used to create GCP resources.

* This PR checks in the config for cluster kf-ci-management.
  We also setup a namespace to administer resources in project
  kubeflow-ci-deployment

Fix kubeflow#644
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
…ubeflow#652)

* Create a simple script to deploy Kubeflow using the GCP blueprint.
  This is basically just a wrapper around make commands.

  * This is the first step in setting up auto deployments of the GCP
    blueprint for CI purposes.

* Fix some bugs in the management cluster that popped up while testing
  the blueprint

  * Fix CNRM install for the kubeflow-ci-deployment namespace.
    CNRM wasn't properly configured to administer that namespace.
   The appropriate role bindings weren't being created in the correct
  namespaces and the statefulset was using the host project and not the
  managed project.

  * See kubeflow#644 for reference on the management cluster settup

  * We should use the kubeflow-testing@kubeflow-ci service account
    and not a service account owned by project kubeflow-ci-deployment
    as the latter is being GC'd by our cleanup ci scripts which breaks
    the management cluster.

  * Also per kubeflow#644 permissions are now set at the folder level to
    prevent the permissions from being GC'd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants