Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Run Bazel build/tests as part of Travis CI #640

Closed
wants to merge 7 commits into from

Conversation

neuromage
Copy link
Contributor

@neuromage neuromage commented Jan 5, 2019

This change is Reviewable

@yebrahim
Copy link
Contributor

yebrahim commented Jan 7, 2019

Thanks for doing this @neuromage!
Is it faster to install the bazel debian package rather than use the install script? (e.g. how it's done in https://github.com/korfuri/bazel-travis)

@neuromage
Copy link
Contributor Author

I don't know if it's faster tbh. But this is how Bazel itself does it for their go rules:
https://github.com/bazelbuild/rules_go/blob/master/.travis.yml

@@ -49,3 +59,25 @@ script:
- gimme -f 1.11.4
- source ~/.gimme/envs/go1.11.4.env
- go test ./...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the lines 49-61?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean 59 - 61? I think we should keep it, as long as want go build / go test to continue to work. Also, it's still what we use to release/build images.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note what we're using bazel for then? I thought we were going to switch everything to bazel. I'd love to keep using go build/test wherever we can because they're much faster, but I also think it's good to be consistent with the build system.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents the problem of #638 where the bazel build is broken at HEAD. Bazel is needed especially when the proto definitions change.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neuromage
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: paveldournov

If they are not already assigned, you can assign the PR to them by writing /assign @paveldournov in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neuromage
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: paveldournov

If they are not already assigned, you can assign the PR to them by writing /assign @paveldournov in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neuromage
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@neuromage: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-sample-test ae188df link /test kubeflow-pipeline-sample-test
kubeflow-pipeline-upgrade-test ae188df link /test kubeflow-pipeline-upgrade-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stale
Copy link

stale bot commented Jun 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 24, 2020
@stale
Copy link

stale bot commented Jul 1, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this Jul 1, 2020
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress lifecycle/stale The issue / pull request is stale, any activities remove this label. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants