-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Run Bazel build/tests as part of Travis CI #640
Conversation
Thanks for doing this @neuromage! |
I don't know if it's faster tbh. But this is how Bazel itself does it for their go rules: |
@@ -49,3 +59,25 @@ script: | |||
- gimme -f 1.11.4 | |||
- source ~/.gimme/envs/go1.11.4.env | |||
- go test ./... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the lines 49-61?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean 59 - 61? I think we should keep it, as long as want go build / go test to continue to work. Also, it's still what we use to release/build images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a note what we're using bazel for then? I thought we were going to switch everything to bazel. I'd love to keep using go build/test wherever we can because they're much faster, but I also think it's good to be consistent with the build system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prevents the problem of #638 where the bazel build is broken at HEAD. Bazel is needed especially when the proto definitions change.
263e73a
to
1a1c364
Compare
80b3c08
to
3adc9d6
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neuromage If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neuromage If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
986b082
to
ae188df
Compare
/retest |
@neuromage: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
This change is