fix(frontend): Update TFX context naming pattern for TFX 1.2.0+. #6387
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @jiyongjung0 |
|
@zijianjoy: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -272,6 +272,7 @@ export class OutputArtifactLoader { | |||
|
|
|||
| // Since artifact types don't change per run, this can be optimized further so | |||
| // that we don't fetch them on every page load. | |||
| console.log('enter TFX for execution ' + execution.getId() + ' namespace ' + namespace); | |||
| const tfxRunContextName = `${pipelineName}.${runID}`; | ||
| return await getContext({ name: tfxRunContextName, type: 'run' }); | ||
| // Context: https://github.com/kubeflow/pipelines/issues/6138 | ||
| // Require TFX version to be > 1.2.0. |
| @@ -267,6 +267,7 @@ class RunDetails extends Page<RunDetailsInternalProps, RunDetailsState> { | |||
| workflow, | |||
| selectedNodeId, | |||
| ); | |||
| console.log('selectedNodeId ' + selectedNodeId); | |||
Description of your changes:
Reference: #6138 (comment)
It is required for TFX version to be > 1.2.0 starting with this change.
Checklist: