SDK/DSL-Compiler - Expand placeholders in command #637
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @qimingj |
|
@Ark-kun: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
There is a similar PR #623 Closing this one |
…eflow#637) * We should no longer need to use self signed ceritificates with auto-deployed instances because GKE ManagedCertificates don't have the SSL quota limits of lets encrypt. * Nonethless fix a bug in the logic for attaching a self signed ceritificate. * We need to delete the managed certificate annotations otherwise the ingress doesn't end up using the self signed ceritifcate and we end up running out of SSL quota. * Creating a playbook directory and start putting the playbooks there. * Related to kubeflow/testing#636 * Don't use self-signed certificates in auto deployments. Lets Encrypt quota should no longer be an issue so always use ManagedCertificates
…ces (kubeflow#637)" (kubeflow#642) Partial revert of commit afd9f95. The change in the self-signed logic breaks presubmits with the following error E kubernetes.client.rest.ApiException: (409) E Reason: Conflict E HTTP response headers: HTTPHeaderDict({'Audit-Id': '85305103-054e-4795-a45e-f802de1ae4ea', 'Content-Type': 'application/json', 'Date': 'Wed, 15 Apr 2020 00:31:03 GMT', 'Content-Length': '352'}) E HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"Operation cannot be fulfilled on ingresses.extensions \"envoy-ingress\": the object has been modified; please apply your changes to the latest version and try again","reason":"Conflict","details":{"name":"envoy-ingress","group":"extensions","kind":"ingresses"},"code":409} * Only changes to util.py in the original PR are reverted.
…ble (kubeflow#637) * Allow tornado num of workers configurable * Add parallelism field * Add parallelism tests * Add num worker tests * Use model server arg constants * Validate parallelism * Update parallelism field comment
Allows using passed arguments in command.
This change is