fix for boostrapp problem #602
Conversation
|
Hi @xiaozhouX. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
Hi @xiaozhouX. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
@xiaozhouX Thanks for the fix |
| @@ -28,8 +28,8 @@ | |||
| argo:: if (deployArgo == true) || (deployArgo == "true") then | |||
| argo.parts(namespace).all | |||
There was a problem hiding this comment.
Does this line need to change as well?
There was a problem hiding this comment.
I thinks it's ok, the argo parts take only one argument.
|
What can we do next with the e2e test failed ? @IronPan |
|
/test kubeflow-pipeline-e2e-test |
* Fix for the bug kubeflow#602 Clears some verbiage for kserve/kserve#602 * remove references to installing KNative through manifests Few people have reported that causes confusion. Either you get KNative and Istio through Kubeflow, or through their respective installation sites * Update Istio versions * fiz istio version
…low#602) * Support latest tektoncd pipeline version. * update readme for support latest tektoncd pipeline version.
Fix for issue #594
This change is