Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat(sdk): block using v2 @component decorator in v1 mode. Fixes #5967 #5989

Closed
wants to merge 11 commits into from
Closed

[WIP] feat(sdk): block using v2 @component decorator in v1 mode. Fixes #5967 #5989

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a0fcfca
Add runtime resource request for GPUs
NikeNano Jul 1, 2021
f44ce55
clean up
NikeNano Jul 3, 2021
0351fda
Updated docks and add check
NikeNano Jul 4, 2021
622c92a
clean up
NikeNano Jul 4, 2021
b5a2c30
update after feedback
NikeNano Jul 5, 2021
92d48a2
Clean up after feedback
NikeNano Jul 6, 2021
9a5bd53
Clean up
NikeNano Jul 7, 2021
08d0ae0
Remove spaces
NikeNano Jul 7, 2021
ae1a2de
fix test
NikeNano Jul 7, 2021
f0988b2
fix condition
NikeNano Jul 7, 2021
6c1e530
fix condition
NikeNano Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sdk/python/kfp/compiler/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,13 @@ def _create_dag_templates(self, pipeline, op_transformers=None, op_to_templates_
pipeline_name=self._pipeline_name_param,
pipeline_root=self._pipeline_root_param,
launcher_image=self._launcher_image)

if op.command is not None and\
len(op.command) > 3 and\
"Executor executes v2-based Python function components." in op.command[3] and\
not self._mode == dsl.PipelineExecutionMode.V2_COMPATIBLE:
raise Exception('@component is not allowed in V1 mode')

templates.extend(op_to_templates_handler(op))

if hasattr(op, 'custom_job_spec'):
Expand Down