-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(launcher): revert metadata to custom properties & artifact name -> event path #5842
chore(launcher): revert metadata to custom properties & artifact name -> event path #5842
Conversation
/lgtm Thank you Yuan for the change! |
/test kubeflow-pipelines-samples-v2 The previous test's sub-pipeline seems finished successfully https://4e18c21c9d33d20f-dot-datalab-vm-staging.googleusercontent.com/#/runs/details/cbbb47bf-f409-4943-a2a9-387f55e942b8, but parent-pipeline didn't get the run status. |
New changes are detected. LGTM label has been removed. |
Thanks @zijianjoy! I fixed it |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Reasons:
Checklist: