Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Remove alphabetical sorting of the metrics column. Fixes #5215 #5701

Merged
merged 4 commits into from
May 27, 2021

Conversation

annajung
Copy link
Member

Signed-off-by: Anna Jung (VMware) antheaj@vmware.com

Description of your changes:
Remove ordering of the metrics so that metrics are displayed in the order it was defined rather than in an alphabetical order

fixes #5215

Checklist:

@google-oss-robot
Copy link

Hi @annajung. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bobgy
Copy link
Contributor

Bobgy commented May 20, 2021

/ok-to-test

Thank you for this contribution!

Anna Jung (VMware) added 3 commits May 26, 2021 10:57
Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>
Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>
Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>
@annajung
Copy link
Member Author

Is there a doc somewhere that I should update as well?

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! a last minor comment

frontend/src/pages/RunList.test.tsx Outdated Show resolved Hide resolved
@Bobgy
Copy link
Contributor

Bobgy commented May 26, 2021

Is there a doc somewhere that I should update as well?

Great to hear this question : )
This is a bug fix, so nothing additional is required

Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>
@Bobgy
Copy link
Contributor

Bobgy commented May 27, 2021

Perfect!
Thank you for working on this fix!
And also the quick iterations based on feedback : )

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy changed the title fix(ui): Remove alphabetical sorting of the metrics column. Fixes #5215 fix(frontend): Remove alphabetical sorting of the metrics column. Fixes #5215 May 27, 2021
@google-oss-robot google-oss-robot merged commit ebf5310 into kubeflow:master May 27, 2021
@annajung
Copy link
Member Author

Thanks for all your help @Bobgy!

Bobgy pushed a commit that referenced this pull request Jun 21, 2021
#5215 (#5701)

* Remove alphabetical sorting of the metrics column

Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>

* Fix code format

Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>

* Refactor test to use data-testid

Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>

* Remove snapshot in favor of text comparison

Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>
Bobgy pushed a commit that referenced this pull request Jun 21, 2021
#5215 (#5701)

* Remove alphabetical sorting of the metrics column

Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>

* Fix code format

Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>

* Refactor test to use data-testid

Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>

* Remove snapshot in favor of text comparison

Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline metrics are always sorted alphabetically
3 participants