Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes await bug in create new run #553

Merged

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Dec 17, 2018

Previously, the await was not actually being applied to the API calls, so a run creation could fail, but the success snackbar would still be shown.


This change is Reviewable

@rileyjbauer
Copy link
Contributor Author

rileyjbauer commented Dec 17, 2018

/assign yebrahim
/area front-end
/kind bug

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rileyjbauer
Copy link
Contributor Author

/test kubeflow-pipeline-build-image

@k8s-ci-robot k8s-ci-robot merged commit 302e93c into kubeflow:master Dec 18, 2018
@rileyjbauer rileyjbauer deleted the fix-await-in-run-api-calls branch May 6, 2019 22:15
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* update go-license-tool README

* fix typo

* address comments
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants