Parameterize mysql and minio image #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @yebrahim |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
…eflow#551) * kubeflow/testing is the central repository where all reusable engprod code goes. As a result it makes sense for the reusable Tekton definitions and scripts related to continuous building and updating of Kubeflow applications to live here * For now, we will also centralize the definition of pipelines for all applications in this repository (as opposed to having them live in the application repositories). * This should make it easier to manage and automatically update all applications. * Per kubeflow/testing#544 redo how we use kustomize and Tekton to parameterize the pipelines. * Individual runs of pipelines will rely completely on Tekton parameter substitution to create a run to build an image for a specific application at a specific commit. * The image URL and git commit of source code will be Tekton PipelineResources that are inlined in the PipelineRun * For any parameters we will use Tekton parameters and inline the values in the PipelineRun * PipelineRuns will just be created as YAML files and not as kustomize overlays * Right now we have a single kustomize package which defines the reusable elements which are Tekton Tasks and Pipeline resources * Right now we have a single Pipeline for all applications but in the future we might have application specific pipelines * rebuild_manifests.sh should use the image tag v0.x.y-${commit} rather than the digest. * This image tagging scheme will be the basis for determining whether the image is already up to date (kubeflow/testing#545) * since we now specify the full image_url rather than using image name we need a parameter for the src_image that is used with the kustomize edit function. * Use a separate task for updating the manifests * Now that we are using image tags of the form "{TAG}-{COMMIT}" which is determined at pipeline construction time; we no longer need to pass the digest file between the build-push step and the update manifests task which makes it much easier to run them as separate task since we don't need a pod volume to share data. Related to kubeflow/testing#450 - CD pipelines for Kubeflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is