Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure dataproc components #542

Merged
merged 3 commits into from
Dec 18, 2018
Merged

Restructure dataproc components #542

merged 3 commits into from
Dec 18, 2018

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Dec 14, 2018

This change is Reviewable

@gaoning777
Copy link
Contributor Author

/cc ironpan qimingj

@qimingj
Copy link
Contributor

qimingj commented Dec 14, 2018

/lgtm

.cloudbuild.yaml Outdated
@@ -125,27 +125,27 @@ steps:
# Build the Dataproc-based pipeline component images
- name: 'gcr.io/cloud-builders/docker'
entrypoint: '/bin/bash'
args: ['-c', 'cd /workspace/components/dataproc/containers/analyze && ./build.sh -p $PROJECT_ID -t $COMMIT_SHA']
args: ['-c', 'cd /workspace/components/dataproc/analyze/src && ./build_image.sh -p $PROJECT_ID -t $COMMIT_SHA']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No /src in these paths.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are correct. Done

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 14, 2018

Thanks for your effort in this restructuring!
The only one remaining will be the resnet-cmle group.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 14, 2018
@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 14, 2018

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 14, 2018

/approve

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 17, 2018

/cc @qimingj

@qimingj
Copy link
Contributor

qimingj commented Dec 17, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 18, 2018

/test kubeflow-pipeline-build-image

@k8s-ci-robot k8s-ci-robot merged commit f1fb2df into kubeflow:master Dec 18, 2018
@gaoning777 gaoning777 deleted the restructure-dataproc branch December 19, 2018 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants