Support GPU image for dnntrainer component #530
Conversation
| @@ -42,12 +50,18 @@ if [ -z "${TAG_NAME}" ]; then | |||
| TAG_NAME=$(date +v%Y%m%d)-$(git describe --tags --always --dirty)-$(git diff | shasum -a256 | cut -c -6) | |||
| fi | |||
|
|
|||
| TF_VERSION=1.6.0 | |||
There was a problem hiding this comment.
TF images have version, CPU/GPU and python version. Maybe we should just add the base image tag command line parameter.
|
/test kubeflow-pipeline-unit-test |
components/third_party_licenses.csv
Outdated
| @@ -169,3 +169,11 @@ tensorflow-tensorboard,https://raw.githubusercontent.com/tensorflow/tensorboard/ | |||
| tensorflow-data-validation,https://raw.githubusercontent.com/tensorflow/data-validation/master/LICENSE,Apache 2.0 | |||
| tensorflow-metadata,https://raw.githubusercontent.com/tensorflow/metadata/master/LICENSE,Apache 2.0 | |||
| defusedxml,https://raw.githubusercontent.com/tiran/defusedxml/master/LICENSE,PSF | |||
| backports.functools-lru-cache,https://raw.githubusercontent.com/jaraco/backports.functools_lru_cache/master/LICENSE,MIT | |||
| cycler,https://raw.githubusercontent.com/matplotlib/cycler/master/LICENSE,MIT | |||
| h5py,https://raw.githubusercontent.com/h5py/h5py/07f3c362887563c1040b10d2cbd8cca49ceac1b9/licenses/license.txt | |||
There was a problem hiding this comment.
https://raw.githubusercontent.com/h5py/h5py/master/licenses/license.txt
|
BTW, what errors do you get when you try using the GPU image on a non-GPU cluster? |
|
/lgtm |
|
I vaguely remember that It's related to CUDA driver not found error. |
|
/assign qimingj |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-e2e-test |
|
@qimingj could you give me another lgtm? thanks. |
|
/lgtm |
Changes:
Future changes:
This change is