Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed dsl/_component.py to dsl/_python_component.py #510

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Renamed dsl/_component.py to dsl/_python_component.py #510

merged 1 commit into from
Dec 14, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Dec 11, 2018 •
edited by jlewi
Loading

The only function in the file is python_component.

This change is Reviewable

gaoning777
gaoning777 reviewed Dec 11, 2018
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why update the name to python_component?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 11, 2018 •
edited
Loading

The only thing in the file is python_component decorator. It seems natural to call the file the same. I think we talked about renaming, but forgot to rename the file itself.

@gaoning777
Copy link
Contributor

IMO, keeping the file name as component is not a bad idea because:
We might add more decorators or classes, functions to the file, and then we need to rename it again? Similar to the pipeline file, use component as the filename is not bad.
WDYT? @qimingj

@qimingj
Copy link
Contributor

qimingj commented Dec 12, 2018

/lgtm

@qimingj
Copy link
Contributor

qimingj commented Dec 12, 2018

I am not picky on file names. Either is fine to me so long as we don't change interface and break existing users.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 14, 2018 •
edited
Loading

We might add more decorators or classes, functions to the file, and then we need to rename it again?

If we add more decorators and we find a better name, we'll rename it.

Similar to the pipeline file, use component as the filename is not bad.

The pipeline file contains the the pipeline decorator and the Pipeline class.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 14, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cdfedeb into kubeflow:master Dec 14, 2018
@gaoning777
Copy link
Contributor

the sample test fails. Can you take a look

@Ark-kun Ark-kun deleted the SDK/Components/Python---Renamed-dsl/_component.py-to-dsl/_python_component.py branch January 21, 2019 11:21
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@ukclivecox @k8s-ci-robot
Fix typo in resources (kubeflow#510)
86de9c2
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
Fix broken links from kubeflow website (kubeflow#510)
cdda44e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 left review comments

@qimingj qimingj qimingj approved these changes

Assignees

@qimingj qimingj

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @gaoning777 @qimingj @k8s-ci-robot