support tpu settings in dsl #491
Conversation
sdk/python/kfp/dsl/_container_op.py
Outdated
| return self | ||
|
|
||
|
|
||
| def set_tpu(self, tpu_cores: str, tpu_resource: str, tf_version: str): |
There was a problem hiding this comment.
tpu_cores: int
Does it make sense to provide defaults?
There was a problem hiding this comment.
I don't think there is a good value for default. User should decide how many TPU they want before enable it.
There was a problem hiding this comment.
I worded my comment wrong. I meant the defaults for tpu_resource and tf_version.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* support tpu settings in dsl * fix issues from review comment
…ubeflow#491) * Increase default timeout to 600s * endpoint specific timeouts
This change is