Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up test - remove unused workflow #483

Merged
merged 3 commits into from
Dec 7, 2018
Merged

clean up test - remove unused workflow #483

merged 3 commits into from
Dec 7, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Dec 5, 2018 •
edited by jlewi
Loading

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Dec 5, 2018

/assign @gaoning777
cc @yebrahim @Ark-kun

@IronPan
Copy link
Member Author

IronPan commented Dec 6, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 6, 2018 •
edited
Loading

@IronPan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
presubmit-e2e-test 627c50a link /test presubmit-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@IronPan
Copy link
Member Author

IronPan commented Dec 6, 2018

/test kubeflow-pipeline-build-image

@IronPan
Copy link
Member Author

IronPan commented Dec 6, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gaoning777
gaoning777 approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit a9d0689 into master Dec 7, 2018
@IronPan IronPan deleted the yangpa/clu branch December 10, 2018 22:26
neuromage pushed a commit to neuromage/pipelines that referenced this pull request Dec 22, 2018
@IronPan @neuromage
clean up test - remove unused workflow (kubeflow#483)
23ca7d2 
* remove

* remove

* remove
@snyk-bot snyk-bot mentioned this pull request May 26, 2021
Open
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@ScrapCodes
fix: Migrate away from old katib api to ResourceOp. (kubeflow#483)
df59ee4 
* fix: Migrate away from old katib api to ResourceOp.

* added success and failure condition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 approved these changes

Assignees

@gaoning777 gaoning777

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IronPan @k8s-ci-robot @gaoning777