Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Adds missing short options to the cli #4604

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

shaikmanu797
Copy link
Contributor

Adds missing short options to be consistent with other cli subcommand options

Checklist:

@google-cla google-cla bot added the cla: yes label Oct 10, 2020
@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @shaikmanu797. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bobgy
Copy link
Contributor

Bobgy commented Oct 10, 2020

Thank you!
/lgtm
/approve
/cc @Ark-kun @numerology

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy added cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch approved and removed approved labels Oct 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit ce6cfa5 into kubeflow:master Oct 10, 2020
@Bobgy Bobgy added the cherrypicked cherry picked to release branch `release-x.y` label Oct 10, 2020
@shaikmanu797 shaikmanu797 deleted the short_options_cli branch October 10, 2020 12:19
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` cla: yes lgtm needs-ok-to-test size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants