fix(backend): persistence agent - workflow not found error should be a permanent error #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bobgy
added
the
cherrypick-approved
|
This change is |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bobgy
added a commit
that referenced
this pull request
Sep 14, 2020
…a permanent error (#4486) * fix(backend): workflow not found error should be permanent * failing test case * Fix logic * fix another case * Switched to not found error * not found error should be permanent
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
…a permanent error (kubeflow#4486) * fix(backend): workflow not found error should be permanent * failing test case * Fix logic * fix another case * Switched to not found error * not found error should be permanent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Fixes #4484
The error happens only when persistence worker cannot update its work queue. The only reported case was caused by too many workflows in the cluster. The error messages are super long and recurring, so they make it impossible to find if there are other errors that caused persistence agent fail to GC workflows.
/area backend