-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): Fix opsgroups dependency resolution #4370
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @sabiroid. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
/assign @Ark-kun @numerology @chensun |
/ok-to-test |
So, some tests seem to have failed, but I am pretty sure my change is not the reason. Are there any action items for me as for now? |
@sabiroid Thank you for this fix for the DSL compiler. P.S. Maybe you can add a small compiler test to the test suite. |
/test kubeflow-pipelines-tfx-python36 |
1 similar comment
/test kubeflow-pipelines-tfx-python36 |
@Ark-kun Sure, it's all in the description! The broken scenario is when something depends on an OpsGroup. Here is an example Python code resulting in an exception without a fix and in correct yaml with a fix: https://gist.github.com/sabiroid/08bb7d8e5a413f7d465bbb119df5449c Also amended the PR with the unit test :) |
/assign @Ark-kun |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test kubeflow-pipeline-upgrade-test |
Description of your changes:
There is a bug in the
Compiler
class when it resolves dependencies forOp
s andOpsGroup
s. The nature of this bug is the following: when a dependency is anOpsGroup
, compiler fails with an uncaught exception because it tries to access the wrong variable. This diff fixes this bug by changing the variable to access.This gist surfaces the bug and proves the fix:
Checklist:
cherrypick-approved
label added to the pull request when it gets accepted? Thanks!cherrypick-approved
label to this PR. The release manager adds this PR to the release branch in a batch update.