Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/Components - Renamed container.arguments to container.args #437

Merged
merged 1 commit into from
Dec 3, 2018
Merged

SDK/Components - Renamed container.arguments to container.args #437

merged 1 commit into from
Dec 3, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Dec 1, 2018 •
edited by jlewi
Loading

This aligns us with Kubernetes spec

This change is Reviewable

@Ark-kun Ark-kun changed the title [WIP]SDK/Components - Renamed container.arguments to container.args SDK/Components - Renamed container.arguments to container.args Dec 1, 2018
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 1, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gaoning777
gaoning777 reviewed Dec 3, 2018
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 3, 2018

/test presubmit-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit e06dc88 into master Dec 3, 2018
@k8s-ci-robot
Copy link
Contributor

@Ark-kun: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
presubmit-e2e-test 51aaa7f link /test presubmit-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Ark-kun Ark-kun deleted the avolkov/SDK/Components---Renamed-container.arguments-to-container.args branch January 15, 2019 22:09
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@jinchihe @k8s-ci-robot
update docs related sdk (kubeflow#437)
128a757
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@yhwang
fix(backend): Update python version in Dockerfile (kubeflow#437)
22203dc 
fix get-pip.py error while using old version
of python (3.5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 left review comments

@qimingj qimingj Awaiting requested review from qimingj

Assignees

@gaoning777 gaoning777

@qimingj qimingj

Labels
approved area/sdk/components lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @k8s-ci-robot @gaoning777 @qimingj