feat(deployment): KFP standalone should keep user data when application deleted #4332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
/approve |
Bobgy
added
the
cherrypick-approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, rmgogogo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jingzhang36
pushed a commit
to jingzhang36/pipelines
that referenced
this pull request
Aug 12, 2020
Bobgy
added a commit
that referenced
this pull request
Aug 12, 2020
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
KFP standalone should keep user data when application deleted.
There's currently a behavior difference when deleting KFP application from https://cloud.console.google.com/ai-platform/pipelines/clusters.
If AI Platform Pipelines is deleted, it keeps data in the cluster.
If KFP standalone is deleted, it deletes data too (non recoverable because underlying GCE persistent disk is auto deleted too). This behavior is very dangerous to me, especially when we document to users they should delete AI Platform Pipelines instance to upgrade.
Checklist: