feat(backend): sort by run metrics - step 2 #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the archive page
…page and the archive page" This reverts commit 5b67273.
…ed at, etc. The lattre are direct field in listable object, the former is an element in an arrary-typed field in listable object. In other words, the latter are columns in table, the former is not.
|
This change is |
jingzhang36
changed the title
Bobgy
reviewed
Jul 20, 2020
|
/lgtm |
2 tasks
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingzhang36 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-frontend-test |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* enable pagination when expanding experiment in both the home page and the archive page * Revert "enable pagination when expanding experiment in both the home page and the archive page" This reverts commit 5b67273. * sorting by run metrics is different from sorting by name, uuid, created at, etc. The lattre are direct field in listable object, the former is an element in an arrary-typed field in listable object. In other words, the latter are columns in table, the former is not. * unit test: add sorting on metrics with both asc and desc order * list is generic. model specific test is put to run_store_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Part of #3591
Sorting by run metrics is different from sorting by name, uuid, created at, etc. The latter are explicit fields in a listable object, the former is an element in an arrary-typed field in a listable object. In other words, the latter are columns in table, the former is not. So sorting by run metric is not sorting by a column in a table as we do for other fields (name, uuid, etc.) before. We'll need to
Note: sorting by other fields keeps the existing behavior. FE behavior keeps the same.
Checklist:
The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
PR titles examples:
fix(frontend): fixes empty page. Fixes #1234Use
fixto indicate that this PR fixes a bug.feat(backend): configurable service account. Fixes #1234, fixes #1235Use
featto indicate that this PR adds a new feature.chore: set up changelog generation toolsUse
choreto indicate that this PR makes some changes that users don't need to know.test: fix CI failure. Part of #1234Use
part ofto indicate that a PR is working on an issue, but shouldn't close the issue when merged.Do you want this pull request (PR) cherry-picked into the current release branch?
If yes, use one of the following options:
cherrypick-approvedlabel to this PR. The release manager adds this PR to the release branch in a batch update.