Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(deployment): separate metadata-writer and metadata-grpc folders #4071

Merged
merged 2 commits into from
Jun 28, 2020
Merged

refactor(deployment): separate metadata-writer and metadata-grpc folders #4071

merged 2 commits into from
Jun 28, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jun 24, 2020 •
edited
Loading

Description of your changes:
Separate metadata-writer and metadata-grpc folders, so that we can reuse metadata-writer easier in Kubeflow 1.1 manifest by referring to the kustomize/base/metadata/metadata-writer folder directly.

/cc @Ark-kun

Checklist:

  • The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

    PR titles examples:

    • fix(frontend): fixes empty page. Fixes #1234
      Use fix to indicate that this PR fixes a bug.
    • feat(backend): configurable service account. Fixes #1234, fixes #1235
      Use feat to indicate that this PR adds a new feature.
    • chore: set up changelog generation tools
      Use chore to indicate that this PR makes some changes that users don't need to know.
    • test: fix CI failure. Part of #1234
      Use part of to indicate that a PR is working on an issue, but shouldn't close the issue when merged.

  • Do you want this pull request (PR) cherry-picked into the current release branch?

    If yes, use one of the following options:

    • (Recommended.) Ask the PR approver to add the cherrypick-approved label to this PR. The release manager adds this PR to the release branch in a batch update.
    • After this PR is merged, create a cherry-pick PR to add these changes to the release branch. (For more information about creating a cherry-pick PR, see the Kubeflow Pipelines release guide.)

@Bobgy Bobgy added the cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch label Jun 24, 2020
@kubeflow-bot
Copy link

This change is Reviewable

@Bobgy Bobgy mentioned this pull request Jun 24, 2020
Merged
2 tasks
@rmgogogo
Copy link
Contributor

+1 to this PR. I plan to deprecate metadata-writer and cache-server someday after we support native MLMD. So does persistence-agent.

/lgtm
/approve

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 24, 2020

I wonder maybe the Metadata Writer belongs more to the backend, not the metadata directory.
The Metadata-gRPC is an external project like Argo, Minio, Envoy, etc, but the Metadata Writer is part of KFP.

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 24, 2020

@Ark-kun good point! will adjust

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 28, 2020
@Bobgy Bobgy added the lgtm label Jun 28, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, rmgogogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2020

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2020

/test kubeflow-pipeline-frontend-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2020

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 28, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@Bobgy Bobgy added the lgtm label Jun 28, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 28, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2020

/test all

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2020

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2020

/test kubeflow-pipeline-backend-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2020

/test kubeflow-pipeline-upgrade-test

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2020

/retest

@Bobgy Bobgy added the lgtm label Jun 28, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2020

/retest

@Bobgy Bobgy mentioned this pull request Jun 28, 2020
Closed
@k8s-ci-robot k8s-ci-robot merged commit c80a8a2 into kubeflow:master Jun 28, 2020
@Bobgy Bobgy deleted the separate_metadata_folder branch June 28, 2020 08:14
@Bobgy Bobgy added the cherrypicked cherry picked to release branch `release-x.y` label Jul 2, 2020
Bobgy added a commit that referenced this pull request Jul 2, 2020
@Bobgy
refactor(deployment): separate metadata-writer and metadata-grpc fold…
51872e4 
…ers (#4071)

* refactor(deployment): separate metadata-writer and metadata-grpc folders

* fix release script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@rmgogogo rmgogogo

Labels
approved cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` cla: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Bobgy @kubeflow-bot @rmgogogo @Ark-kun @k8s-ci-robot @googlebot