Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add notebook sample test #397

Closed
wants to merge 12 commits into from
Closed

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 28, 2018

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gaoning777

If they are not already assigned, you can assign the PR to them by writing /assign @gaoning777 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor Author

solving #263

@gaoning777
Copy link
Contributor Author

/test presubmit-unit-test

@gaoning777
Copy link
Contributor Author

/test presubmit-sample-test

@gaoning777
Copy link
Contributor Author

/test presubmit-sample-test

@gaoning777
Copy link
Contributor Author

/retest

1 similar comment
@gaoning777
Copy link
Contributor Author

/retest

@gaoning777
Copy link
Contributor Author

/test presubmit-sample-test

@gaoning777 gaoning777 closed this Dec 4, 2018
@gaoning777 gaoning777 deleted the ngao/notebook-sample-test branch February 8, 2019 18:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* We weren't properly paginating through the results; we need to reset
  nextPageToken when switching zones

  * Due to this bug cleanup_disks wasn't actually being called we were just
    error'ing out and cleanup_ci was ignoring this error.

* We weren't calling execute on the delete request

* We needed more regexes to match disks to be deleted.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…and unified predictor concept with explainer/transformer (kubeflow#397)

* Fixes issues with Validation not applying to transformers/explainers

* Added Validation classes

* more changes

* Standardized terminology around predictors

* Renames

* Added predictor

* other renames and fixes

* adding swagger

* Moved more validation logic to predictor

* Fixed validation

* Fixed validation

* Fixed configmap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants