Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Fixes the length of component digest label #3934

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

numerology
Copy link

Only 63 chars are allowed. Previously the length was 64.

@kubeflow-bot
Copy link

This change is Reviewable

@numerology
Copy link
Author

/assign @Ark-kun

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 9, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 9, 2020

/retest

2 similar comments
@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 9, 2020

/retest

@numerology
Copy link
Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7fbb7ca into kubeflow:master Jun 9, 2020
numerology pushed a commit to numerology/pipelines that referenced this pull request Jun 10, 2020
(cherry picked from commit 7fbb7ca)
k8s-ci-robot pushed a commit that referenced this pull request Jun 10, 2020
(cherry picked from commit 7fbb7ca)
@numerology numerology deleted the fix-digest-length branch June 10, 2020 05:21
RedbackThomson pushed a commit to RedbackThomson/pipelines that referenced this pull request Jun 17, 2020
numerology pushed a commit to numerology/pipelines that referenced this pull request Jun 26, 2020
k8s-ci-robot pushed a commit that referenced this pull request Jun 27, 2020
* Revert "fix length (#3934)"

This reverts commit 7fbb7ca

* Revert "[SDK] Add first party component label (#3861)"

This reverts commit 1e2b9d4

* Revert "[SDK] Add pod labels for telemetry purpose. (#3578)"

This reverts commit aa8da64
Bobgy pushed a commit that referenced this pull request Jul 2, 2020
* Revert "fix length (#3934)"

This reverts commit 7fbb7ca

* Revert "[SDK] Add first party component label (#3861)"

This reverts commit 1e2b9d4

* Revert "[SDK] Add pod labels for telemetry purpose. (#3578)"

This reverts commit aa8da64
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Revert "fix length (kubeflow#3934)"

This reverts commit 7fbb7ca

* Revert "[SDK] Add first party component label (kubeflow#3861)"

This reverts commit 1e2b9d4

* Revert "[SDK] Add pod labels for telemetry purpose. (kubeflow#3578)"

This reverts commit aa8da64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants