Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Fix missing $TAG_NAME in .cloudbuild.yaml #3921

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jun 5, 2020

Fixes #3000

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign paveldournov
You can assign the PR to them by writing /assign @paveldournov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 5, 2020

/cc @rmgogogo
I'll merge the fix first

@Bobgy Bobgy merged commit 62959d5 into kubeflow:master Jun 5, 2020
@Bobgy Bobgy deleted the fix_tag_name_cloudbuild branch June 5, 2020 05:38
RedbackThomson pushed a commit to RedbackThomson/pipelines that referenced this pull request Jun 17, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Show KFP version text on UI
3 participants