SDK/Tests/Components - Improve temporary file handling #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ark-kun
changed the title
Ark-kun
changed the title
|
/test mlpipeline-presubmit-sample-test |
|
/lgtm |
|
/approve |
* fix tfx name bug * update release build for the data publish
|
/approve |
|
/lgtm |
|
@Ark-kun: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@Ark-kun: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 7, 2018
* Moves docs from the /samples README to the wiki I've copied all the info from the googleprivate/samples README.md to the wiki. This PR removes most of the content from the README, adds a simple introduction, and points people to the wiki docs for further information. Relevant wiki files: https://github.com/kubeflow/pipelines/wiki/Deploy-the-Kubeflow-Pipelines-Service https://github.com/kubeflow/pipelines/wiki/Build-a-Pipeline https://github.com/kubeflow/pipelines/wiki/Build-Your-Own-Component * SDK/Tests/Components - Improve temporary file handling (#37) * Improve temporary file handling in python op tests * More small temp path fixes * Fix tfx name bug in the tfma sample test (#67) * fix tfx name bug * update release build for the data publish * SDK/DSL/Compiler - Fixed compilation of dsl.Condition (#28) * Fixed compilation of dsl.Conditional The compiler no longer produced intermediate steps. * Got rid of _create_new_groups * Changed the sub_group.type check * Fix tfx name bug in the tfma sample test (#67) * fix tfx name bug * update release build for the data publish * Build Python SDK in the releasing (#70) * publish python sdk in the cloud build * update cloudbuild * adjust output path * add dependency for buildapiserver * mlp -> kfp.dsl (#88) * Removed instruction to clone the repo. * Changed link to samples doc on wiki. * Add %%docker magic to jupyter kernel. It helps submitting a docker build job more easily with one cell. (#72) * fix miscellaneous List API issue (#90) * fix * Update job_store.go * Update run_store.go * Update presubmit-tests.sh * Update job_store.go * Moves docs from pipelines main README to wiki (#83) I've copied all the info from the kubeflow/pipelines README.md to the wiki. This PR removes most of the content from the README, adds a simple introduction, and points people to the wiki docs for further information. Relevant wiki files: https://github.com/kubeflow/pipelines/wiki https://github.com/kubeflow/pipelines/wiki/Deploy-the-Kubeflow-Pipelines-Service https://github.com/kubeflow/pipelines/wiki/Build-a-Pipeline * SDK/DSL/Compiler - Reverted fix of dsl.Condition until the UI is ready. (#94) * sort by run display name by default (#96) * CSS changes for nav menu and tables (#99) * debug tfma failure (#91) * debug tfma failure * tft version bug * minor fix * comment the test validation * Fix validation check for maximum size limit (#104) * Fixed the Minikube tests after moving to the new repo (#98) * Don't barf when experiment name is already used (#101) * don't barf when experiment name is already used * make mock backend use case insensitive names * ExperimentList tests, use immer.js (#86) * experiment list tests * use produce in more places * remove extra test * remove extra import * Use the experiment's resource reference in the listJobs request (#105) * use the experiment's resource reference in the listJobs request * fix test import * Add Ning and Alexey to OWNERS for components, samples and sample-test (#102) * Compile samples instead of hard code them in API server (#76) * compile samples * update logging * update description * update sample * add immediate value sample * revert * fail fast if the samples are failed to load * comment * address comments * comment out * update command * comments * Account for padding in metric progress fill (#107) * Account for padding in metric progress fill * small mock backend fix * move to css classes, add color * changes to breadcrumb style * increase width of summary card * tests * merge tests * First integration test for the ML Pipeline CLI (Pipeline List). (#81) * First integration test for the ML Pipeline CLI (Pipeline List). * Fixing an issue with an undefined variable * Adding the --debug flag to help with debugging. * Changing the namespace to Kubeflow. * Add tests for the NewExperiment page (#109) * Add tests for the NewExperiment page * Fix test name * Remove obsolete tests * Clean up * add xgboost: migrate from the old repo (#46) * migrate from the old repo * fix bug: accidentally override tfma test * add tfma test back * add tfma back * typo fix * fix small typo * if job fails, exit after logs are output * Remove CMLE sample for now since we are waiting for a service fix to support TPU. (#113) * image tag update for release (#114) * update image tag for new releases * add more * delete the accidentaly added sample * fix typo (#116) * Fix an issue that %%docker doesn't work. (#119) * updated favicon to monochrome color (#118) * Expanded row changes (#120) * updated favicon to monochrome color * simple CSS changes to expanded row * Removed mentions of ark7 in tests (#111) * Add basic sample tests (#79) * add sequential sample test * add condition basic sample * reuse script * add all the other basic tests * update sample test dockerfile to add run_basic_test file * write test output * typo bug
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
…-ci (kubeflow#37) The environment points to the new cluster under project kubeflow-ci spec.json has the cluster ip. params.libsonnet overwrites the nfs server ip.
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Change e2e test job to point to kserve repo * Fix prow config * Remove dir dep * fix image-transformer built image tag (kubeflow#44) * fix image-transformer built image tag Signed-off-by: Theofilos Papapanagiotou <theofilos@gmail.com> * rename ecr registry directory for kserve Signed-off-by: Theofilos Papapanagiotou <theofilos@gmail.com> * merging kserve branch to master (kubeflow#35) * KServe Go module and API group change -------------------------------------- Updated go source files with new go module. Changed apigroup in yaml files. Made changes in Makefile to represent the repository and apigroup names. Verified `make test` is passing. Removed reference for old names. * Pointed correct repo reference for ko images (kubeflow#23) * Rename changes python - New (kubeflow#19) * python changes-initial-commit * updated api gen. Renamed package references in python. * Renamed python/kfserving to python/kserve * renamed python folder according to package kserve * Ran client-gen. Updated swagger.json * renamed constants from KFSERVING_ to KSERVE_. Yet to change namespace from kfserving-system to kserve and hence not changed in python side. * Updated kfserving reference to kserve Updated version for Python Package Index to 0.7.0rc0 Renamed KFServingSampleModel to KServeSampleModel * Python package and corresponding directory change has to be reflected in test and dockerfiles * updated a specific version in requirments to address issue with pip resolver. Added more specific versions in requirements,txt and updated paddleserver setup.py with kserve dependency. * Changed namespace from kfserving-system to kserve (kubeflow#31) * Update local dev scripts (kubeflow#33) * initial commit of dev-scripts update * Updated quick-install * Updated python Makefile * Generated install for new release * Updated generate-install script with new release * Reverting controller name in makefile. Will be updated in separate pr. * Github action changes (kubeflow#34) * Github action changes Migrated images publish to kserve repo. Added github workflows for the ones that was being pushed to gcr.io from release/triggers. * Removed batcher publisher since batcher.Dockerfile does not exist Updated tf2openapi.Dockerfile to correct directory and package. * Fixed issue with working directory of tf2openapi workflow * Removed the deptrecated logger docker * Excluded tests from linting. (kubeflow#36) They were pointing to older directory and package names and hence were not being excluded while linting. * Update license (kubeflow#20) * Fixed errors thrown by flake8 linter (kubeflow#37) * Kfserving kserve manifests changes and code reference changes (kubeflow#39) * kfserving -> kserve migartion initial commit * kfserving -> kserve config changes * Changed constants. Updated image reference from kserve to andyarok * Reverted kserve models web app image repo. * go changes for kfserving-kserve * Updated KFServing refernce in python code * Updated KFServing to KServe in python doc comments. Updated references of v1alpha2 from duplicate aliases to just use pkg name. Updated docs samples references with proper name. Made changes to use Constant for container name instead of literal "kserve-container". * Updated gitignore for generated files that came in after folder rename. Removed the generated files. Fixed lint warnings for go. * Removed travis yml file. * KServe doc update (kubeflow#38) * Update main and pythonserver readme * Update python docs * Fix role binding * Update kserve sdk doc * Fix e2e test script * Fix import * Kserve error fix (kubeflow#40) * Fixed linting errors in python * Fixed make test. Issue with storage initializer name/path. * Fixed failing python test. Updated ray version. Updated KFServingClient reference to KServeClient in kserve init. * Updated ray version from 1.4.0 to 1.5.0 * Fixed error with e2e due to kfserving reference in test overlay (kubeflow#42) Updated quick install and added 0.7.0-rc0 install manifests. Updated e2e namespace. * Controller repo update (kubeflow#45) Made changes in workflow to update image repo to kserve instead of kfserving * Controller repo update (kubeflow#45) Made changes in workflow to update image repo to kserve instead of kfserving * update pytorch image * Fix transformer dockerfile Co-authored-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Co-authored-by: andyi2it <87992092+andyi2it@users.noreply.github.com> * Generate 0.7.0 release candidate and update roadmap/release process (kubeflow#46) * Fix apiVersion for examples and docs (kubeflow#55) Fix apiVersion for examples and docs change from serving.kubeflow.org to serving.kserve.io * add default deployment and fix startup without knative to master branch (kubeflow#57) * add default deployment and fix startup without knative * fix suite_test error * fix suit_test error * add constant vb for RawDeployment and Serverless * update predictor string RawDeployment to constants.RawDeployment * modify getDeploymentMode return type * Update kserve layer diagram (kubeflow#58) * update diag (kubeflow#59) * Remove kubeflow copyright (kubeflow#56) * Adding kfs_architect.drawio and changing kfs_architect.png's "KFserving" name to "KServe" (kubeflow#60) * Delete kfs_architect.png * Add files via upload Adding kfs_architect.drawio and changing kfs_architect.png's "KFserving" name to "KServe" * Delete kfs_architect.png * Delete kfs_architect.drawio * added Metric scrapping title * Delete kfs_architect.png * Delete kfs_architect.drawio * fixed typo * add Nick Hill as a reviewer (kubeflow#66) also removing rkelkar * Separate out web-app repo (kubeflow#68) * Sepate out web-app repo * Remove models web-app github action * Fix feast example Co-authored-by: Theofilos Papapanagiotou <theofilos@gmail.com> Co-authored-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Co-authored-by: andyi2it <87992092+andyi2it@users.noreply.github.com> Co-authored-by: Chin Huang <chhuang@us.ibm.com> Co-authored-by: Qingshan Chen <38182824+Iamlovingit@users.noreply.github.com> Co-authored-by: Animesh Singh <singhan@us.ibm.com> Co-authored-by: js-ts <79689323+js-ts@users.noreply.github.com>
HumairAK
referenced
this pull request
in red-hat-data-services/data-science-pipelines
Mar 11, 2024
Change keras dependency to a stable version
HumairAK
added a commit
to HumairAK/data-science-pipelines
that referenced
this pull request
May 16, 2024
chore: upgrade node to v18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just switching from temporary files to temporary directory.
This change is