Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deployment] Fix metadata envoy configuration #3502

Merged
merged 1 commit into from
Apr 14, 2020
Merged

[Deployment] Fix metadata envoy configuration #3502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/kustomize/base/metadata/metadata-envoy-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
spec:
containers:
- name: container
image: gcr.io/ml-pipeline/envoy:initial
image: gcr.io/ml-pipeline/envoy:metadata-grpc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you mean MKP path failed.
Wondering whether we change it like MKP path to use 0.4.0 version like other containers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried MKP path, from release.cloudbuild.yaml looks like it builds this image each time.

It would be good if we change like that, but I don't forsee any updates. I think this fix is fine for now.

ports:
- name: md-envoy
containerPort: 9090
Expand Down