Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipelineDetails cleanup #350

Merged
merged 5 commits into from
Nov 21, 2018
Merged

PipelineDetails cleanup #350

merged 5 commits into from
Nov 21, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Nov 21, 2018

This PR refactors a few corners of the PipelineDetails page into separate components. Overall it does this:

  • Move title into DetailsTable component, since almost all its uses were adding a title div.
  • Refactor side panel logic into a new component that can be opened, can show busy spinner, title, and calls back when closed. This is reused in PipelineDetails and RunDetails.
  • Refactor rendering static graph node details into a separate simple component to make testing easier.

This change is Reviewable

Copy link
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. testing should be a bit easier now

frontend/src/components/SidePanel.tsx Outdated Show resolved Hide resolved
frontend/src/components/SidePanel.tsx Outdated Show resolved Hide resolved
frontend/src/pages/RunDetails.tsx Outdated Show resolved Hide resolved
@rileyjbauer
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit d313a9c into master Nov 21, 2018
@yebrahim yebrahim deleted the yebrahim/pipeline-details branch November 22, 2018 06:23
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Update v1alpha2 sdk and notebook

* Remove notebook output and deprecated files

* update requirement links

* Remove deprecated readme files

* Fix unit test

* Fix lint

* add back output

* Add watcher on notebook

* Add canary promote to notebook

* formatting
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants