Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] Skip host name preprocess for the IAP case #3427

Merged
merged 1 commit into from
Apr 3, 2020
Merged

[SDK] Skip host name preprocess for the IAP case #3427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/python/kfp/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ def _load_config(self, host, client_id, namespace, other_client_id, other_client

host = host or ''
# Preprocess the host endpoint to prevent some common user mistakes.
host = re.sub(r'^(http|https)://', '', host).rstrip('/')
# This should only be done for non-IAP cases (when client_id is None). IAP requires preserving the protocol.
if not client_id:
host = re.sub(r'^(http|https)://', '', host).rstrip('/')

if host:
config.host = host
Expand Down