Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Recycle upgrade- clusters and reduce time lapse #3282

Merged
merged 1 commit into from
Mar 16, 2020
Merged

[Testing] Recycle upgrade- clusters and reduce time lapse #3282

merged 1 commit into from
Mar 16, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Mar 16, 2020 •
edited by jlewi
Loading

Two changes:

  1. also recycle clusters with upgrade- prefix
  2. Recycle clusters earlier, 2 hours after test finish can reduce some test flakiness caused by too many clusters in the project

/assign @dushyanthsc

This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 16, 2020

/retest

@dushyanthsc
Copy link
Contributor

/lgtm
/approve

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 16, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, dushyanthsc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy mentioned this pull request Mar 16, 2020
Closed
@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 16, 2020

Part of #1638

@k8s-ci-robot k8s-ci-robot merged commit 5f858cc into kubeflow:master Mar 16, 2020
@Bobgy Bobgy deleted the test_recycle_upgrade_cluster branch March 16, 2020 07:08
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Bobgy @Jeffwan
[Testing] Recycle upgrade- clusters and reduce time lapse (kubeflow#3282
1dd77e0 
)
@snyk-bot snyk-bot mentioned this pull request May 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@rmgogogo rmgogogo Awaiting requested review from rmgogogo

Assignees

@dushyanthsc dushyanthsc

Labels
approved area/engprod area/testing lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bobgy @dushyanthsc @k8s-ci-robot