Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add presto pipeline component #3261

Merged

Conversation

mertkavi
Copy link
Contributor

@mertkavi mertkavi commented Mar 11, 2020

A Kubeflow Presto Pipeline component to submit a query to Presto.


This change is Reviewable

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

Hi @mertkavi. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mertkavi
Copy link
Contributor Author

@googlebot I signed it! and we'll verify it.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 11, 2020

It seems that this component does not have any outputs.
Usually, components have outputs so that the data they produce can be used.

@mertkavi
Copy link
Contributor Author

@Ark-kun Presto queries write a file by nature. For example, create table programs with (format = 'parquet') ... query create a table and write Parquet files to Object Storage. That's why this component has not output.

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 12, 2020

@Ark-kun Presto queries write a file by nature. For example, create table programs with (format = 'parquet') ... query create a table and write Parquet files to Object Storage. That's why this component has not output.

Even if the component creates something in an external system, it's useful to have outputs. You can output table name, object id or URI. Then a downstream component can use that to run another query or read the data. Even if something like table name comes from input it's still useful to "pass-through" and output it. This a way of establishing dependencies between tasks.

@mertkavi
Copy link
Contributor Author

Thank you for comment @Ark-kun I added the output.

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 13, 2020

Are there going to be other presto-related components in the future? If so, it might be better to move the code to, say, components/presto/query/. Usually the path schema is company_name[/group_name]/component_name/.

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 13, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

@mertkavi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 13, 2020
@mertkavi
Copy link
Contributor Author

Are there going to be other presto-related components in the future? If so, it might be better to move the code to, say, components/presto/query/. Usually the path schema is company_name[/group_name]/component_name/.

It makes sense. I moved it.

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 14, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1e95241 into kubeflow:master Mar 15, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* add presto pipeline component

* add output to component

* move the code to organization-component folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants