Use ks env for pipeline namespace #326
Conversation
|
/assign @Ark-kun |
test/presubmit-tests.sh
Outdated
| @@ -80,7 +80,7 @@ if [ "$CLUSTER_TYPE" == "create-gke" ]; then | |||
| echo "Delete cluster..." | |||
| gcloud container clusters delete ${TEST_CLUSTER} --async | |||
| } | |||
| trap delete_cluster EXIT | |||
| # trap delete_cluster EXIT | |||
There was a problem hiding this comment.
do not forget to uncomment this line before merging.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* [WIP] change deployment platform to gcp * debug * revert test * use upper case for ks parameter * Update deploy.sh * Update presubmit-tests.sh * Use ks env for pipeline namespace (#326) * [WIP] change deployment platform to gcp * debug * revert test * use env for namespace * set ns correctly * Update presubmit-tests.sh * revert
This is to align with other kubeflow components
This change is