Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TFX to 0.21.1 #3220

Merged
merged 4 commits into from
Mar 6, 2020
Merged

Bump TFX to 0.21.1 #3220

merged 4 commits into from
Mar 6, 2020

Conversation

numerology
Copy link

@numerology numerology commented Mar 5, 2020

This change is Reviewable

@numerology
Copy link
Author

/hold

@numerology
Copy link
Author

/hold cancel

@numerology
Copy link
Author

/retest

@numerology
Copy link
Author

/retest

One more try then I'm going to take a look at GKE setup

@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rmgogogo
Copy link
Contributor

rmgogogo commented Mar 6, 2020

/cc Bobgy as you changed TFMA

Is it tested locally? standalone CLI can help a quick test

@k8s-ci-robot k8s-ci-robot requested a review from Bobgy March 6, 2020 01:02
@k8s-ci-robot
Copy link
Contributor

@rmgogogo: GitHub didn't allow me to request PR reviews from the following users: as, you, changed, TFMA.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc Bobgy as you changed TFMA

Is it tested locally? standalone CLI can help a quick test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@numerology
Copy link
Author

numerology commented Mar 6, 2020

/cc Bobgy as you changed TFMA

Is it tested locally? standalone CLI can help a quick test

It looks okay at https://465b70d4a3050db6-dot-us-central2.pipelines.googleusercontent.com/#/runs/details/4cc460ce-1e58-4c77-99fb-c9ee5110a2b1

Per offline discussion there'll be some further change:

  • Deprecate ModelValidator
  • Add a keras native sample.

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Are these samples covered in presubmit tests?

test/deploy-cluster.sh Show resolved Hide resolved
@numerology
Copy link
Author

/lgtm
Are these samples covered in presubmit tests?

Yes they are.

@Bobgy
Copy link
Contributor

Bobgy commented Mar 6, 2020

Right, @numerology Can you verify if TFMA/TFDV visualizations are still working?
Unfortunately, we don't have e2e test coverage yet

@k8s-ci-robot k8s-ci-robot merged commit ee525b9 into kubeflow:master Mar 6, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Mar 6, 2020

UPDATE: discussed offline, verified they still work

@numerology numerology deleted the bump-tfx-0211 branch March 6, 2020 02:14
@numerology
Copy link
Author

UPDATE: will update the GKE master version in the following PRs

Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* bump

* pin two requirements.txt

* update sample

* try a newer k8s version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants