revert #3168 as it doesn't work for MKP, put myself to reviewer #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmgogogo
referenced
this pull request
Feb 28, 2020
* minio: Set secure=true to enable TLS by default Not using TLS is a security concern, especially if using cloud storage like S3. This should be set to secure to avoid people unknowingly not using TLS. To make the bundled minio still work, I've submitted kubeflow/manifests#950 to set secure=false in this case explicitly. * minio: secure=false in GCP & standalone manifests
Bobgy
changed the title
|
@rmgogogo Can you add yourself as reviewer in a separate commit? and also adjusted title to reflect where it was actually broken |
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
…flow#3191) Co-authored-by: renmingu <40223865+renmingu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is