Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start page updates according latest feedback #3175

Merged
merged 2 commits into from
Feb 26, 2020
Merged

start page updates according latest feedback #3175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d3bbb6
done
Feb 26, 2020
8b61617
start page done
Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/Css.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
*/

import createMuiTheme from '@material-ui/core/styles/createMuiTheme';
import { NestedCSSProperties } from 'typestyle/lib/types';
import { style, stylesheet } from 'typestyle';
import { NestedCSSProperties } from 'typestyle/lib/types';

export const color = {
activeBg: '#eaf1fd',
Expand Down Expand Up @@ -72,6 +72,7 @@ export const fontsize = {
medium: 16,
large: 18,
title: 18,
pageTitle: 24,
};
// tslint:enable:object-literal-sort-keys

Expand Down
16 changes: 8 additions & 8 deletions frontend/src/components/Toolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@
* limitations under the License.
*/

import * as React from 'react';
import ArrowBackIcon from '@material-ui/icons/ArrowBack';
import BusyButton from '../atoms/BusyButton';
import ChevronRightIcon from '@material-ui/icons/ChevronRight';
import IconButton from '@material-ui/core/IconButton';
import Tooltip from '@material-ui/core/Tooltip';
import ArrowBackIcon from '@material-ui/icons/ArrowBack';
import ChevronRightIcon from '@material-ui/icons/ChevronRight';
import { History } from 'history';
import * as React from 'react';
import { CSSProperties } from 'react';
import { Link } from 'react-router-dom';
import { classes, stylesheet } from 'typestyle';
import { spacing, fonts, fontsize, color, dimension, commonCss } from '../Css';
import { CSSProperties } from 'react';
import BusyButton from '../atoms/BusyButton';
import { color, commonCss, dimension, fonts, fontsize, spacing } from '../Css';

export interface ToolbarActionMap {
[key: string]: ToolbarActionConfig;
Expand Down Expand Up @@ -92,8 +92,8 @@ const css = stylesheet({
},
pageName: {
color: color.strong,
fontSize: fontsize.title,
lineHeight: `${backIconHeight}px`,
fontSize: fontsize.pageTitle,
lineHeight: '28px',
},
root: {
alignItems: 'center',
Expand Down
13 changes: 3 additions & 10 deletions frontend/src/pages/GettingStarted.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,10 @@ const PAGE_CONTENT_MD = ({
}) => `
<br/>

## Build your own pipeline
## Build your own pipeline with

Build an end-to-end ML pipeline with TensorFlow Extended (TFX) [**Start Here!**](https://console.cloud.google.com/mlengine/notebooks/deploy-notebook?q=download_url%3Dhttps%253A%252F%252Fraw.githubusercontent.com%252Ftensorflow%252Ftfx%252Fmaster%252Fdocs%252Ftutorials%252Ftfx%252Ftemplate.ipynb) (Please make sure you pick a Tensorflow 2.1 notebook instance.)
* TensorFlow Extended (TFX) end-to-end ML Pipeline Template ([Open Notebook](https://console.cloud.google.com/mlengine/notebooks/deploy-notebook?q=download_url%3Dhttps%253A%252F%252Fraw.githubusercontent.com%252Ftensorflow%252Ftfx%252Fmaster%252Fdocs%252Ftutorials%252Ftfx%252Ftemplate.ipynb))
* Kubeflow Pipelines [SDK](https://www.kubeflow.org/docs/pipelines/sdk/)

<br/>

Expand All @@ -70,14 +71,6 @@ This section contains demo and tutorial pipelines.
* [DSL - Control structures](${control}) - Shows how to use conditional execution and exit handlers. [source code](https://github.com/kubeflow/pipelines/tree/master/samples/tutorials/DSL%20-%20Control%20structures)

Want to learn more? [Learn from sample and tutorial pipelines.](https://www.kubeflow.org/docs/pipelines/tutorials/)

<br/>

### Additional resources and documentation
* [TFX documentation](https://www.tensorflow.org/tfx)
* [AI Platform Pipelines documentation](https://cloud.google.com/ai-platform/pipelines/docs/)
* [Troubleshooting guide](https://cloud.google.com/ai-platform/pipelines/docs/troubleshooting/)
* [Kubeflow Pipelines documentation](https://www.kubeflow.org/docs/pipelines/)
`;

cssRaw(`
Expand Down
91 changes: 27 additions & 64 deletions frontend/src/pages/__snapshots__/GettingStarted.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,35 @@ exports[`GettingStarted page initially renders documentation 1`] = `
<div>
<br />
<h2
id="build-your-own-pipeline"
id="build-your-own-pipeline-with"
>
Build your own pipeline
Build your own pipeline with
</h2>
<p>
Build an end-to-end ML pipeline with TensorFlow Extended (TFX)
<a
class="link"
href="https://console.cloud.google.com/mlengine/notebooks/deploy-notebook?q=download_url%3Dhttps%253A%252F%252Fraw.githubusercontent.com%252Ftensorflow%252Ftfx%252Fmaster%252Fdocs%252Ftutorials%252Ftfx%252Ftemplate.ipynb"
rel="noopener"
target="_blank"
>
<strong>
Start Here!
</strong>
</a>
(Please make sure you pick a Tensorflow 2.1 notebook instance.)
</p>
<ul>
<li>
TensorFlow Extended (TFX) end-to-end ML Pipeline Template (
<a
class="link"
href="https://console.cloud.google.com/mlengine/notebooks/deploy-notebook?q=download_url%3Dhttps%253A%252F%252Fraw.githubusercontent.com%252Ftensorflow%252Ftfx%252Fmaster%252Fdocs%252Ftutorials%252Ftfx%252Ftemplate.ipynb"
rel="noopener"
target="_blank"
>
Open Notebook
</a>
)
</li>
<li>
Kubeflow Pipelines
<a
class="link"
href="https://www.kubeflow.org/docs/pipelines/sdk/"
rel="noopener"
target="_blank"
>
SDK
</a>
</li>
</ul>
<br />
<h2
id="demonstrations-and-tutorials"
Expand Down Expand Up @@ -151,54 +162,6 @@ exports[`GettingStarted page initially renders documentation 1`] = `
Learn from sample and tutorial pipelines.
</a>
</p>
<br />
<h3
id="additional-resources-and-documentation"
>
Additional resources and documentation
</h3>
<ul>
<li>
<a
class="link"
href="https://www.tensorflow.org/tfx"
rel="noopener"
target="_blank"
>
TFX documentation
</a>
</li>
<li>
<a
class="link"
href="https://cloud.google.com/ai-platform/pipelines/docs/"
rel="noopener"
target="_blank"
>
AI Platform Pipelines documentation
</a>
</li>
<li>
<a
class="link"
href="https://cloud.google.com/ai-platform/pipelines/docs/troubleshooting/"
rel="noopener"
target="_blank"
>
Troubleshooting guide
</a>
</li>
<li>
<a
class="link"
href="https://www.kubeflow.org/docs/pipelines/"
rel="noopener"
target="_blank"
>
Kubeflow Pipelines documentation
</a>
</li>
</ul>
</div>
</div>
</div>
Expand Down