[Sample] Disable multi-threading for TFX demo notebook #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In TFX 0.21.0 release it's not guaranteed to work well with 6 vCPU. Disable it for now.
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmgogogo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
rmgogogo
reviewed
Feb 26, 2020
| @@ -239,7 +239,7 @@ | |||
| " trainer, model_analyzer, model_validator, pusher\n", | |||
| " ],\n", | |||
| " enable_cache=True,\n", | |||
| " beam_pipeline_args=['--direct_num_workers=%d' % 4],\n", | |||
| " beam_pipeline_args=['--direct_num_workers=%d' % 1],\n", | |||
There was a problem hiding this comment.
would prefer you set it as 0 as it will be auto selected based on available cpus.
and maybe refine the title
|
/hold Left comments. please update to 0 which solve all problem. |
|
/hold cancel |
|
/lgtm |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* [Sample] Disable multi-threading for TFX demo notebook In TFX 0.21.0 release it's not guaranteed to work well with 6 vCPU. Disable it for now. * Update taxi_pipeline_notebook.ipynb Co-authored-by: Yuan (Bob) Gong <gongyuan94@gmail.com>
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…le (kubeflow#3170) Add go security scan Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TFX 0.21.0 release it's not guaranteed to work well with 6 vCPU. Disable it for now.
This change is