Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend]: Use Promise.all to fetch clusterName and projectId #3140

Merged
merged 1 commit into from
Feb 21, 2020
Merged

[frontend]: Use Promise.all to fetch clusterName and projectId #3140

merged 1 commit into from
Feb 21, 2020

Conversation

Kriyszig
Copy link
Contributor

@Kriyszig Kriyszig commented Feb 21, 2020

Parallelizing async API calls using Promise.all instead of using two awaits.

Issue in focus

There are no issues related to this. It is a minor performance related improvement and makes the code consistent across the repository for fetching clusterName and projectId - For example, the same format is followed here in /frontend/src/components/SideNav.tsx


This change is Reviewable

Parallelizing async API calls using Promise.all instead of using
two await
@k8s-ci-robot
Copy link
Contributor

Hi @Kriyszig. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bobgy
Copy link
Contributor

Bobgy commented Feb 21, 2020

/ok-to-test
/lgtm
/approve
@Kriyszig Thanks for the contribution!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 82b87bc into kubeflow:master Feb 21, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…low#3140)

Parallelizing async API calls using Promise.all instead of using
two await
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants