-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch set() to add() for better inheritance. #312
Conversation
/lgtm P.S. In another PR, let's make all |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test presubmit-e2e-test |
Current format is every 8 minutes, changed the spec to be every 8 hours.
We will have a gcpOp that add some default volumes to the container, and we should allow upper level ops inheriting gcpOp to add more volumes, envs if they want.
A concrete example is having a op that read a GCS data and push to github. In this case I want to mount both GCP secret volume and Git secret volume.
TODO: we can add a batch method to add a list of resources, but that's not must have right now.
This change is