Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch set() to add() for better inheritance. #312

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 19, 2018

We will have a gcpOp that add some default volumes to the container, and we should allow upper level ops inheriting gcpOp to add more volumes, envs if they want.

A concrete example is having a op that read a GCS data and push to github. In this case I want to mount both GCP secret volume and Git secret volume.

TODO: we can add a batch method to add a list of resources, but that's not must have right now.


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Nov 19, 2018

/assign @qimingj @Ark-kun

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 19, 2018

/lgtm

P.S. In another PR, let's make all set/add operations chainable by adding return self. For future single-value chainable setters, a good naming is with_something.

@IronPan
Copy link
Member Author

IronPan commented Nov 19, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member Author

IronPan commented Nov 19, 2018

/test presubmit-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit dfcf92b into master Nov 19, 2018
@IronPan IronPan deleted the yangpa/add branch December 10, 2018 22:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Current format is every 8 minutes, changed the spec to be every 8 hours.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants