Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Deduplicate requests to gke metadata #3117

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 19, 2020

Mitigates #3070 by making sure only one cluster-name, project-name request will ever be made.

Implementation: move sidenav component to top level, so that its instance never changes (previously, its instance changes on each navigation).

/area frontend


This change is Reviewable

@Bobgy Bobgy changed the title Move sidenav to top level, so its instance never changes [UI] Deduplicate requests to gke metadata Feb 19, 2020
@Bobgy Bobgy self-assigned this Feb 19, 2020
@Bobgy Bobgy added the kind/bug label Feb 19, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 19, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 19, 2020

/retest

1 similar comment
@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 19, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 24d77ed into kubeflow:master Feb 19, 2020
@Bobgy Bobgy deleted the fe_save_gke_metadata_reqs branch February 24, 2020 12:44
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants