Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualization] Clean up full.tpl to improve vis loading time #3116

Merged
merged 4 commits into from
Feb 19, 2020
Merged

[Visualization] Clean up full.tpl to improve vis loading time #3116

merged 4 commits into from
Feb 19, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 19, 2020 •
edited
Loading

Mitigates #3114 (comment)

/cc @ajchili
/area visualization

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

@Bobgy: The label(s) area/visualization cannot be applied, because the repository doesn't have them

In response to this:

Mitigates #3114 (comment)

/area visualization

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 19, 2020 •
edited by jlewi
Loading

@Bobgy: The label(s) area/visualization cannot be applied, because the repository doesn't have them

In response to this:

Mitigates #3114 (comment)

/area visualization

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 19, 2020 •
edited by jlewi
Loading

@Bobgy: The label(s) area/visualization cannot be applied, because the repository doesn't have them

In response to this:

Mitigates #3114 (comment)

/cc @ajchili
/area visualization

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jingzhang36
Copy link
Contributor

/lgtm
/approve

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 19, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, jingzhang36

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 842b0ce into kubeflow:master Feb 19, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Bobgy @Jeffwan
[Visualization] Clean up full.tpl to improve vis loading time (kubefl…
011bfc6 
…ow#3116)

* Remove @jupyter/html-manager from full.tpl

* Include visualization server cloudbuild yaml to facilitate local dev

* Stop fallback behavior of KFP UI to improve dev experience
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@rachitchauhan43
Fix: error response handling for splitter and switch nodes (kubeflow#…
8231072 
…3116)

* Refactoring common code to a function

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

* Added e2e test cases for splitter nodes

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

* Fixed linting errors

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

* Minor refactoring for error message

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

---------

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingzhang36 jingzhang36 jingzhang36 approved these changes

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@jingzhang36 jingzhang36

Labels
approved area/backend lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bobgy @k8s-ci-robot @jingzhang36