[UI] deep links to pipeline details page from start page #3086

Bobgy · 2020-02-14T13:05:23Z

/cc @jingzhang36
/assign @SinaChavoshi
/area frontend

This change is

frontend/src/pages/GettingStarted.tsx

numerology · 2020-02-14T17:12:10Z

Thanks @Bobgy ! LGTM as a quick fix. As for a long-term solution, I'm wondering can we stop baking a predefined set of pipelines into our backend server? Instead, we might automatically download pipeline packages automatically when the backend server spin up. Then, IIUC, in resource manager we can get the actual link (which depends on the pipeline ID) and put it on the landing page.

Compile and publish the pipeline packages could be part of the releasing process. I think it may also help us to apply quick fix to samples as well.

WDYT? @IronPan @rmgogogo @jingzhang36

Bobgy · 2020-02-15T03:30:30Z

/approve

k8s-ci-robot · 2020-02-15T03:30:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [Bobgy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Bobgy · 2020-02-15T03:34:48Z

Thanks @Bobgy ! LGTM as a quick fix. As for a long-term solution, I'm wondering can we stop baking a predefined set of pipelines into our backend server? Instead, we might automatically download pipeline packages automatically when the backend server spin up. Then, IIUC, in resource manager we can get the actual link (which depends on the pipeline ID) and put it on the landing page.

Compile and publish the pipeline packages could be part of the releasing process. I think it may also help us to apply quick fix to samples as well.

WDYT? @IronPan @rmgogogo @jingzhang36

Sounds like a good idea to me. Just confirmation, do we also make an extra api endpoint just to query sample ids?

Bobgy · 2020-02-15T03:42:18Z

/retest

Bobgy · 2020-02-15T03:51:22Z

/retest

…es into fe_start_link_to_pipelines

Bobgy · 2020-02-15T04:16:20Z

I'd like to add three more changes:

let frontend import names from a json file
add a presubmit test check to verify names are synced with backend
add simple unit tests for this components.

will update next monday

EDIT: these changes are all done. I think it's relatively safe now. WDUT?

Bobgy · 2020-02-16T14:31:35Z

@numerology Can we improve error message of this? I'm not sure what the exception is, it seems it should have more info.
https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/3096/kubeflow-pipeline-sample-test/1228980064243159041#1:build-log.txt%3A6347

pipelines/test/sample-test/utils.py

Line 40 in 646aa5f

print('error in get_artifact_in_minio: %s', e)

Bobgy · 2020-02-16T14:32:22Z

/retest

… configs are synced

…pipelines

rmgogogo · 2020-02-17T04:15:09Z

I'd like to add three more changes:

let frontend import names from a json file

add a presubmit test check to verify names are synced with backend

add simple unit tests for this components.

will update next monday

EDIT: these changes are all done. I think it's relatively safe now. WDUT?

OK. Thanks.

frontend/src/config/sample_config_from_backend.json

rmgogogo · 2020-02-17T04:19:38Z

(if this one is hard to be continued, it's also find we just let the link points to the list, just want to save your bandwidth)

Bobgy · 2020-02-17T04:31:48Z

(if this one is hard to be continued, it's also find we just let the link points to the list, just want to save your bandwidth)

I think the solution is complete, can you check again?

numerology · 2020-02-17T05:40:53Z

Thanks @Bobgy ! LGTM as a quick fix. As for a long-term solution, I'm wondering can we stop baking a predefined set of pipelines into our backend server? Instead, we might automatically download pipeline packages automatically when the backend server spin up. Then, IIUC, in resource manager we can get the actual link (which depends on the pipeline ID) and put it on the landing page.
Compile and publish the pipeline packages could be part of the releasing process. I think it may also help us to apply quick fix to samples as well.
WDYT? @IronPan @rmgogogo @jingzhang36

Sounds like a good idea to me. Just confirmation, do we also make an extra api endpoint just to query sample ids?

IMHO that seems not a p0 requirement at this moment. Anyway no need to make such changes in this PR.

Bobgy · 2020-02-17T12:12:54Z

@numerology @renming, thank you for the suggestions. can one of you lgtm?

rmgogogo · 2020-02-17T15:24:41Z

/lgtm
Thanks. It's hard task.

* [UI] deep links to pipeline details page from start page * Fix * Update GettingStarted.tsx * Update GettingStarted.tsx * Update GettingStarted.tsx * Adjust format to improve readability * Use react-testing-library for getting started page tests * Add error case unit tests * Frontend import sample config from jsonn and presubmit test to verify configs are synced * Update presubmit test error message * Changed to sync only sample_config.json name to frontend * Improve error message * Fix tests

…3086) * Refactor autoscaler functionality into an interface. Add no-op autoscaler so users disable creation of autoscaler resources. Add AutoscalerClassNone feature with test cases Signed-off-by: jooho <jlee@redhat.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Rollback getHPAMetrics to set ScaleTarget,ScaleMetric Signed-off-by: jooho <jlee@redhat.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fix merge conflict Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fix autoscaler api group Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fix autoscaler merge Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fix autoscaling tests Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Updated hpa disable test. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Replaced "AutoscalerClassNone" with "AutoscalerClassExternal" Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fixed autoscalerClass 'external' go test. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> --------- Signed-off-by: jooho <jlee@redhat.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Co-authored-by: Curtis Maddalozzo <curtis@tractable.ai> Co-authored-by: jooho <jlee@redhat.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net>

Bobgy added 2 commits February 14, 2020 21:02

[UI] deep links to pipeline details page from start page

fe9aacf

Fix

171f270

k8s-ci-robot assigned SinaChavoshi Feb 14, 2020

k8s-ci-robot added the area/frontend label Feb 14, 2020

k8s-ci-robot requested a review from jingzhang36 February 14, 2020 13:05

k8s-ci-robot added the size/L label Feb 14, 2020

rmgogogo reviewed Feb 14, 2020

View reviewed changes

frontend/src/pages/GettingStarted.tsx Outdated Show resolved Hide resolved

Bobgy added 2 commits February 15, 2020 00:23

Update GettingStarted.tsx

ee971b8

Update GettingStarted.tsx

04ff413

k8s-ci-robot added the approved label Feb 15, 2020

Update GettingStarted.tsx

c6a7d75

Bobgy added the lgtm label Feb 15, 2020

Bobgy added 2 commits February 15, 2020 12:10

Adjust format to improve readability

87ccb3e

Merge branch 'fe_start_link_to_pipelines' of github.com:Bobgy/pipelin…

1706f7d

…es into fe_start_link_to_pipelines

k8s-ci-robot removed the lgtm label Feb 15, 2020

Bobgy mentioned this pull request Feb 15, 2020

UI page & demo title updates #3088

Closed

Use react-testing-library for getting started page tests

28a37a1

k8s-ci-robot added size/XL and removed size/L labels Feb 16, 2020

Bobgy added 2 commits February 17, 2020 09:10

Add error case unit tests

23bdda8

Frontend import sample config from jsonn and presubmit test to verify…

b587fdf

… configs are synced

Bobgy added 2 commits February 17, 2020 11:57

Update presubmit test error message

d0e49fc

Merge remote-tracking branch 'upstream/master' into fe_start_link_to_…

779881f

…pipelines

rmgogogo reviewed Feb 17, 2020

View reviewed changes

frontend/src/config/sample_config_from_backend.json Outdated Show resolved Hide resolved

Bobgy added 3 commits February 17, 2020 12:23

Changed to sync only sample_config.json name to frontend

f14f0ec

Improve error message

d99ccb4

Fix tests

b0ce9ab

k8s-ci-robot assigned rmgogogo Feb 17, 2020

k8s-ci-robot added the lgtm label Feb 17, 2020

k8s-ci-robot merged commit 9b723bf into kubeflow:master Feb 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UI] deep links to pipeline details page from start page #3086

[UI] deep links to pipeline details page from start page #3086

Bobgy commented Feb 14, 2020 •

edited

Loading

numerology commented Feb 14, 2020

Bobgy commented Feb 15, 2020

k8s-ci-robot commented Feb 15, 2020

Bobgy commented Feb 15, 2020

Bobgy commented Feb 15, 2020

Bobgy commented Feb 15, 2020

Bobgy commented Feb 15, 2020 •

edited

Loading

Bobgy commented Feb 16, 2020 •

edited

Loading

Bobgy commented Feb 16, 2020

rmgogogo commented Feb 17, 2020

rmgogogo commented Feb 17, 2020

Bobgy commented Feb 17, 2020

numerology commented Feb 17, 2020

Bobgy commented Feb 17, 2020

rmgogogo commented Feb 17, 2020

[UI] deep links to pipeline details page from start page #3086

[UI] deep links to pipeline details page from start page #3086

Conversation

Bobgy commented Feb 14, 2020 • edited Loading

numerology commented Feb 14, 2020

Bobgy commented Feb 15, 2020

k8s-ci-robot commented Feb 15, 2020

Bobgy commented Feb 15, 2020

Bobgy commented Feb 15, 2020

Bobgy commented Feb 15, 2020

Bobgy commented Feb 15, 2020 • edited Loading

Bobgy commented Feb 16, 2020 • edited Loading

Bobgy commented Feb 16, 2020

rmgogogo commented Feb 17, 2020

rmgogogo commented Feb 17, 2020

Bobgy commented Feb 17, 2020

numerology commented Feb 17, 2020

Bobgy commented Feb 17, 2020

rmgogogo commented Feb 17, 2020

Bobgy commented Feb 14, 2020 •

edited

Loading

Bobgy commented Feb 15, 2020 •

edited

Loading

Bobgy commented Feb 16, 2020 •

edited

Loading