Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Make it explicit that hosted beta does not require GCP SA #3066

Merged
merged 5 commits into from
Feb 13, 2020
Merged

[Doc] Make it explicit that hosted beta does not require GCP SA #3066

merged 5 commits into from
Feb 13, 2020

Conversation

numerology
Copy link

@numerology numerology commented Feb 12, 2020 •
edited by jlewi
Loading

This change is Reviewable

@numerology
Copy link
Author

/hold

html tag does not work

@numerology
Copy link
Author

/hold cancel

@rui5i
Copy link
Contributor

rui5i commented Feb 12, 2020

/lgtm

@numerology
Copy link
Author

/approve

@rui5i
Copy link
Contributor

rui5i commented Feb 12, 2020

/retest

@rmgogogo
Copy link
Contributor

/lgtm
/approve

@rmgogogo
Copy link
Contributor

/retest

@rmgogogo
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: numerology, rmgogogo
To complete the pull request process, please assign ironpan
You can assign the PR to them by writing /assign @ironpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rmgogogo rmgogogo merged commit f89ce80 into kubeflow:master Feb 13, 2020
@numerology numerology deleted the polish-permission-section branch February 13, 2020 18:16
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Jeffwan
[Doc] Make it explicit that hosted beta does not require GCP SA (kube…
4d9d39d 
…flow#3066)
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Update poetry lock files (kubeflow#3066)
f2f0717 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmgogogo rmgogogo rmgogogo left review comments

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@rmgogogo rmgogogo

@rui5i rui5i

Labels
lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@numerology @rui5i @rmgogogo @k8s-ci-robot