Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config fieldname PipelineFolder to PipelinePath #3056

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

eterna2
Copy link
Contributor

@eterna2 eterna2 commented Feb 12, 2020

With reference to PR #2080 :

param to customize the pipeline path to save the pipeline templates (PipelineFolder) was supposed to be renamed to PipelinePath. However, the config.json as well as the config field was not renamed.

This PR fix this oversight - i.e. rename the config field to PipelinePath, and updates the config.json.

cc: @Jeffwan


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @eterna2. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Member

Jeffwan commented Feb 12, 2020

/lgtm

Looks like an open ssl issue inside build container.

error: RPC failed; curl 56 GnuTLS recv error (-54): Error in the pull function.
	fatal: the remote end hung up unexpectedly
	fatal: early EOF
	fatal: index-pack failed
go: error loading module requirements

@Jeffwan
Copy link
Member

Jeffwan commented Feb 12, 2020

/retest

1 similar comment
@Jeffwan
Copy link
Member

Jeffwan commented Feb 15, 2020

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 18, 2020

/ok-to-test

@Bobgy Bobgy removed their assignment Feb 19, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Feb 19, 2020

@jingzhang36 @IronPan for review

@Jeffwan
Copy link
Member

Jeffwan commented Feb 24, 2020

@Ark-kun @jingzhang36 @IronPan kindly ping. :D

@Jeffwan
Copy link
Member

Jeffwan commented Mar 4, 2020

@Bobgy @neuromage Could you help approve this PR? This is a follow up PR of #2080 :

@Bobgy
Copy link
Contributor

Bobgy commented Mar 5, 2020

/approve
/lgtm

There are no existing usages, it's safe to rename.
@jingzhang36 for backend approval

@Bobgy
Copy link
Contributor

Bobgy commented Mar 5, 2020

/assign @IronPan
will be online soon

@IronPan
Copy link
Member

IronPan commented Mar 5, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan
Copy link
Member

Jeffwan commented Mar 5, 2020

/test kubeflow-pipeline-frontend-test

@k8s-ci-robot k8s-ci-robot merged commit 13b2c18 into kubeflow:master Mar 5, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants