Set auto-added artifacts optional in recurring run (job) #3041
Conversation
|
/assign @IronPan |
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-sample-test |
|
|
||
| // Marking auto-added artifacts as optional. Otherwise most older workflows will start failing after upgrade to Argo 2.3. | ||
| // TODO: Fix the components to explicitly declare the artifacts they really output. | ||
| // TODO: Change the compiler to stop auto-adding those two atrifacts to all tasks. |
There was a problem hiding this comment.
IIRC the compiler no longer adds those two artifact to all tasks. @Ark-kun can you correct me if I'm wrong?
There was a problem hiding this comment.
Yes. The compiler stopped doing this in SDK v0.1.29: #2046.
Pipelines compiled by older SDKs have the artifacts hardcoded in them.
There was a problem hiding this comment.
I believe no. That's why I was asking :)
There was a problem hiding this comment.
Great to know. I'll remove the complier TODO, and also the compiler TODO in the one-time run.
|
/retest |
1 similar comment
|
/retest |
|
/test kubeflow-pipeline-e2e-test |
|
/lgtm |
|
/lgtm |
|
/test kubeflow-pipeline-e2e-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Set auto-added artifacts optional in recurring run (job) * Remove out-of-date TODOs.
We set them optional already for one-time run (#1289). We should also set them for recurring run.
Manual test on kfp deployment.
This change is