Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for getting started page #3038

Merged
merged 7 commits into from
Feb 13, 2020
Merged

Updates for getting started page #3038

merged 7 commits into from
Feb 13, 2020

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Feb 11, 2020 •
edited by jlewi
Loading

Includes:

  1. Sample page link update
  2. Template link update
  3. Description for TFX / XGboost corrected
  4. Added a build your own sample for TFX pipeline.

This change is Reviewable

@SinaChavoshi
Copy link
Contributor Author

image

@SinaChavoshi SinaChavoshi force-pushed the getting_started_page_UI branch from 7eac753 to 12bd999 Compare February 11, 2020 16:02
joeliedtke
joeliedtke reviewed Feb 11, 2020
View reviewed changes
Copy link
Member

@joeliedtke joeliedtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments, its looking good!

frontend/src/pages/GettingStarted.tsx Outdated Show resolved Hide resolved
frontend/src/pages/GettingStarted.tsx Show resolved Hide resolved
frontend/src/pages/GettingStarted.tsx Outdated Show resolved Hide resolved
frontend/src/pages/GettingStarted.tsx Outdated Show resolved Hide resolved
frontend/src/pages/GettingStarted.tsx Outdated Show resolved Hide resolved
frontend/src/pages/GettingStarted.tsx Outdated Show resolved Hide resolved
frontend/src/pages/GettingStarted.tsx Outdated Show resolved Hide resolved
@SinaChavoshi
Copy link
Contributor Author

image

@SinaChavoshi SinaChavoshi changed the title [WIP] updates for getting started page Updates for getting started page Feb 12, 2020
@SinaChavoshi SinaChavoshi changed the title Updates for getting started page [WIP] Updates for getting started page Feb 12, 2020
@SinaChavoshi SinaChavoshi changed the title [WIP] Updates for getting started page Updates for getting started page Feb 12, 2020
@rmgogogo
Copy link
Contributor

/lgtm

@yuan, your PR seems can be reverted as this PR handled all.

@Bobgy
Copy link
Contributor

Bobgy commented Feb 12, 2020

@rmgogogo FYI, this is me.
I don't think there are any conflicts with my changes. LGTM

@Bobgy
Copy link
Contributor

Bobgy commented Feb 12, 2020

/approve

@rmgogogo
Copy link
Contributor

/approve

@rmgogogo
Copy link
Contributor

@rmgogogo FYI, this is me.
I don't think there are any conflicts with my changes. LGTM

sorry, didn't expect it will at another one named Yuan.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, rmgogogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Feb 13, 2020

/lgtm

@Bobgy Bobgy merged commit 9b9d5dd into kubeflow:master Feb 13, 2020
@k8s-ci-robot
Copy link
Contributor

@SinaChavoshi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-sample-test 7aa0d49 link /test kubeflow-pipeline-sample-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SinaChavoshi SinaChavoshi deleted the getting_started_page_UI branch February 14, 2020 15:55
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@SinaChavoshi @Bobgy @Jeffwan
Updates for getting started page (kubeflow#3038)
f15bce2 
* link and text update based on bug bash

* Update links and notes

* update text and links

* changing the sample pipeline name to TFX

* updated the pipeline doc link

* updating the  TFX template link

Co-authored-by: Yuan (Bob) Gong <gongyuan94@gmail.com>
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@sivanantha321
Add ARM64 arch support for serving runtimes (kubeflow#3038)
32be746 
Except for Paddle, which does not support arm64/aarch64

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeliedtke joeliedtke joeliedtke left review comments

@Bobgy Bobgy Awaiting requested review from Bobgy

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@Ark-kun Ark-kun

@rmgogogo rmgogogo

@Bobgy Bobgy

@numerology numerology

@joeliedtke joeliedtke

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SinaChavoshi @rmgogogo @Bobgy @k8s-ci-robot @joeliedtke @Ark-kun @numerology