-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Samples] Update preloaded samples' descriptions #3034
Conversation
/assign @SinaChavoshi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…olish-landing-page
New changes are detected. LGTM label has been removed. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
* Add annotation for secret name overrides Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Remove the field Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Fix secret name annotation Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Update kserve url storage example docs Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Address review comments Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Update config docs for storage secret Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Fix storage secret name Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Add test for secret name annotation override Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Fix flake8 lint Signed-off-by: Dan Sun <dsun20@bloomberg.net> --------- Signed-off-by: Dan Sun <dsun20@bloomberg.net>
To better accommodate hosted beta situation.
This change is