Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

place holder for diagnose entry #3028

Merged
merged 1 commit into from
Feb 12, 2020
Merged

place holder for diagnose entry #3028

merged 1 commit into from
Feb 12, 2020

Conversation

rmgogogo
Copy link
Contributor

@rmgogogo rmgogogo commented Feb 10, 2020 •
edited by jlewi
Loading

  • It's to be launched from Cloud Shell or any CLI.
  • It may still reuse existing diagnose tool inside KFP SDK, so bash will install KFP
  • Or it may directly run gcloud and kubectl to do checking or all a golang/python script if bash is hard to handle complex logics.

This change is Reviewable

@rmgogogo
Copy link
Contributor Author

g3 is in cl/148258447

SinaChavoshi
SinaChavoshi approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e344b74 into kubeflow:master Feb 12, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@rmgogogo @Jeffwan
done (kubeflow#3028)
a36d430 
Co-authored-by: renmingu <40223865+renmingu@users.noreply.github.com>
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@ReToCode
add documentation about storage-initializer userid for istio-cni (kub…
9aadd29 
…eflow#3028)

Signed-off-by: Reto Lehmann <retocode@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SinaChavoshi SinaChavoshi SinaChavoshi approved these changes

@IronPan IronPan Awaiting requested review from IronPan

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@SinaChavoshi SinaChavoshi

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmgogogo @k8s-ci-robot @SinaChavoshi